Centralize and type no_default#8171
Conversation
| FutureWarning, | ||
| ) | ||
| n_workers = 0 | ||
| elif not isinstance(n_workers, int) or n_workers < 1: |
There was a problem hiding this comment.
deprecated since Aug 2022
There was a problem hiding this comment.
same here. These should be separate changes
| FutureWarning, | ||
| ) | ||
| n_workers = 0 | ||
| elif not isinstance(n_workers, int) or n_workers < 1: |
There was a problem hiding this comment.
Deprecated since Aug 2022
| await asyncio.gather(set_var("foo"), set_var("bar")) | ||
|
|
||
|
|
||
| def test_serialize_for_cli_deprecated(): |
There was a problem hiding this comment.
All these were deprecated since 2021
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files ± 0 21 suites ±0 11h 13m 7s ⏱️ + 40m 10s For more details on these failures, see this check. Results for commit b972e31. ± Comparison against base commit 1650ceb. ♻️ This comment has been updated with latest results. |
crusaderky
force-pushed
the
no_default
branch
from
8a5eb33 to
83220b8
Compare
| "parse_bytes": "dask.utils.parse_bytes", | ||
| "parse_timedelta": "dask.utils.parse_timedelta", | ||
| "typename": "dask.utils.typename", | ||
| "tmpfile": "dask.utils.tmpfile", |
There was a problem hiding this comment.
All these were deprecated since 2021
There was a problem hiding this comment.
In the interest of a meaningful changelog, I'm inclined to split off these changes. The title of this PR will end up in the changelog and nothing in there says anything about removing deprecated functionality or configuration
crusaderky
force-pushed
the
no_default
branch
2 times, most recently
from
b9fa07d to
683837e
Compare
crusaderky
force-pushed
the
no_default
branch
3 times, most recently
from
c1f4e15 to
69ed182
Compare
fjetter
left a comment
fjetter
left a comment
There was a problem hiding this comment.
I don't mind the changes themselves but I would like us to adopt a better habit of communicating these changes properly. The mechanism right now is to put PR titles into the changelog.
| "parse_bytes": "dask.utils.parse_bytes", | ||
| "parse_timedelta": "dask.utils.parse_timedelta", | ||
| "typename": "dask.utils.typename", | ||
| "tmpfile": "dask.utils.tmpfile", |
There was a problem hiding this comment.
In the interest of a meaningful changelog, I'm inclined to split off these changes. The title of this PR will end up in the changelog and nothing in there says anything about removing deprecated functionality or configuration
| FutureWarning, | ||
| ) | ||
| n_workers = 0 | ||
| elif not isinstance(n_workers, int) or n_workers < 1: |
There was a problem hiding this comment.
same here. These should be separate changes
crusaderky
force-pushed
the
no_default
branch
2 times, most recently
from
6400e84 to
43cbe2f
Compare
crusaderky
force-pushed
the
no_default
branch
from
43cbe2f to
b972e31
Compare
|
@fjetter ready for review again |
3 participants
no_defaultdask#10495n_workersdeprecation inwait_for_workers#8192distributed.utils#8193