Fix test of cudf spilling metrics#8478
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 9h 56m 16s ⏱️ + 12m 16s For more details on these failures, see this check. Results for commit 2734b0f. ± Comparison against base commit e30a3e4. |
|
rerun tests |
charlesbluca
left a comment
There was a problem hiding this comment.
Thanks @madsbk! Approving for now as I'd like to unblock GPU CI as soon as possible, but worth noting that it does seem like this method has issues in test_rmm_metrics that make it flaky:
https://gpuci.gpuopenanalytics.com/job/dask/job/distributed/job/prb/job/distributed-prb/8309/
|
rerun tests |
rjzamora
left a comment
There was a problem hiding this comment.
This is a good fix. CI failures are unrelated.
|
Planning to merge later this afternoon unless there are concerns |
The current implementation of
test_cudf_metrics()sometimes fails because it doesn't wait for the worker's metrics to update. Fixed in this PR.Is it possible to wait on a worker's metrics to update? In
test_rmm_metrics()and now intest_cudf_metrics(), we useawait asyncio.sleep(1), which isn't ideal.pre-commit run --all-filescc. @charlesbluca