Standardize and increase async_poll_for timeout#9248
Merged
Conversation
crusaderky
added
flaky test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async_for_poll asked for explicit timeout. This was typically 5 or 10s; sometimes less.
Standardize it as 15s and set it as default. We really don't care to have tests fail 5s faster in CI if they're broken - whereas a timeout too short may cause flakiness due to the github actions hypervisor chocking the VM for several seconds.
Also change from the wall clock to the monotonic clock, as the former could cause random test failures in case of system clock updates via NTP or simiilar.