Allow unknown remote object size#431
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 74.05% 74.08% +0.03%
==========================================
Files 150 150
Lines 9954 9980 +26
==========================================
+ Hits 7371 7394 +23
- Misses 1824 1826 +2
- Partials 759 760 +1 ☔ View full report in Codecov by Sentry. |
masih
approved these changes
Mar 6, 2024
Sankara-Jefferson
pushed a commit
that referenced
this pull request
Jun 14, 2025
This PR handles the edge case when remote data source report object size as unknown (-1) * The size will not be part of the condition to determine if this file already exists in the database * Once prepared, the size of the file will be updated to the correct size Caveats * Since the size is unknown, it's possible that the files within a job may overflow the sector size * A warning message is logged so the user is aware
anjor
pushed a commit
to anjor/singularity
that referenced
this pull request
Jun 14, 2025
This PR handles the edge case when remote data source report object size as unknown (-1) * The size will not be part of the condition to determine if this file already exists in the database * Once prepared, the size of the file will be updated to the correct size Caveats * Since the size is unknown, it's possible that the files within a job may overflow the sector size * A warning message is logged so the user is aware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles the edge case when remote data source report object size as unknown (-1)
Caveats