Devcontainer-based CI flow#586
Conversation
ccfaccd to
cf692f7
Compare
lanzafame
left a comment
There was a problem hiding this comment.
This looks good to me. Minor comment on removing some of the old test util functions.
f1b18b8 to
df9e7b4
Compare
- initial devcontainer configuration - postgres and mysql database initialization scripts - database startup scripts and permission fixes - password and connectivity configuration
- workarounds for volume relabeling issues - podman-specific configurations - devcontainer re-engineering for podman compatibility - missing scripts and permission fixes
- mysql user and permission fixes - database role creation - test database setup
- job selection logic fix - suppress missing table warnings in tests - disable dag generation during duplicate piece test - resolve record changed since last read errors
- use v2 action - reorder steps for fast fail - remove stray files
df9e7b4 to
effb9a2
Compare
|
ok, this was rebased onto the good tag (v0.6.0-RC3), however |
|
after some consideration I'd propose saving current |
|
I've saved the work in https://github.com/data-preservation-programs/singularity/tree/abandoned/main -- opting for branch over tag as tags may get GC'd if not referenced by a branch (it may also confuse goreleaser) @ianconsolata could you give me prems to change branch protection rules, or temporatily un-protect main? I will also need access to this to change the checks required for merging to the ones from this PR |
14727a8 to
d6211dd
Compare
(cleaned up version of #585 -- the history got so hairy that internal rebasing broke on that branch)
MOTIVATION
the workflows in this repo were historically based on PL templates/work patterns, with complex matrix builds, multi-container orchestration, and a huge number of action dependencies
this resulted in repeated breakage due to actions changing, versions not being pinned fully/going out of sync, new golang releases changing linting rules, etc
numerous efforts were made to get that CI workflow working reliably (#443, #436, #467, #581, etc) but ultimately this all feels like threading water at best
to make matters worse, testing the workflows locally is a giant headache because even
actdoesn't provide an isomorphic environment to what happens on the runners and is not feature complete; normalmake testoutput diverges heavily between local dev and CIPROPOSAL
NOTE: we're using https://github.com/parkan/github-actions to run a rootless podman devcontainer because:
NOTES/REMAINING