Skip to content

improve lotus API test survivability #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parkan merged 1 commit into from
Oct 31, 2025
Merged

improve lotus API test survivability #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion handler/wallet/import_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ import (
)

func TestImportHandler(t *testing.T) {
testutil.SkipIfNotExternalAPI(t)
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
lotusClient := util.NewLotusClient("https://api.node.glif.io/rpc/v0", "")
lotusClient := util.NewLotusClient(testutil.TestLotusAPI, "")

t.Run("success", func(t *testing.T) {
w, err := Default.ImportHandler(ctx, db, lotusClient, ImportRequest{
Expand Down
18 changes: 9 additions & 9 deletions service/dealpusher/dealpusher_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func (m *MockDealMaker) MakeDeal(ctx context.Context, walletObj model.Wallet, ca

func TestDealMakerService_Start(t *testing.T) {
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
service, err := NewDealPusher(db, "https://api.node.glif.io", "", 1, 10)
service, err := NewDealPusher(db, testutil.TestLotusAPI, "", 1, 10)
require.NoError(t, err)
ctx, cancel := context.WithCancel(ctx)
exitErr := make(chan error, 1)
Expand All @@ -78,9 +78,9 @@ func TestDealMakerService_Start(t *testing.T) {

func TestDealMakerService_MultipleInstances(t *testing.T) {
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
service1, err := NewDealPusher(db, "https://api.node.glif.io", "", 1, 10)
service1, err := NewDealPusher(db, testutil.TestLotusAPI, "", 1, 10)
require.NoError(t, err)
service2, err := NewDealPusher(db, "https://api.node.glif.io", "", 1, 10)
service2, err := NewDealPusher(db, testutil.TestLotusAPI, "", 1, 10)
require.NoError(t, err)
ctx, cancel := context.WithTimeout(ctx, time.Second)
defer cancel()
Expand All @@ -99,7 +99,7 @@ func TestDealMakerService_FailtoSend(t *testing.T) {
waitPendingInterval = time.Minute
}()
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
service, err := NewDealPusher(db, "https://api.node.glif.io", "", 2, 0)
service, err := NewDealPusher(db, testutil.TestLotusAPI, "", 2, 0)
require.NoError(t, err)
mockDealmaker := new(MockDealMaker)
service.dealMaker = mockDealmaker
Expand Down Expand Up @@ -153,7 +153,7 @@ func TestDealMakerService_Cron(t *testing.T) {
waitPendingInterval = time.Minute
}()
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
service, err := NewDealPusher(db, "https://api.node.glif.io", "", 1, 10)
service, err := NewDealPusher(db, testutil.TestLotusAPI, "", 1, 10)
require.NoError(t, err)
mockDealmaker := new(MockDealMaker)
service.dealMaker = mockDealmaker
Expand Down Expand Up @@ -250,7 +250,7 @@ func TestDealMakerService_ScheduleWithConstraints(t *testing.T) {
waitPendingInterval = time.Minute
}()
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
service, err := NewDealPusher(db, "https://api.node.glif.io", "", 1, 10)
service, err := NewDealPusher(db, testutil.TestLotusAPI, "", 1, 10)
require.NoError(t, err)
mockDealmaker := new(MockDealMaker)
service.dealMaker = mockDealmaker
Expand Down Expand Up @@ -359,7 +359,7 @@ func TestDealMakerService_ScheduleWithConstraints(t *testing.T) {

func TestDealmakerService_Force(t *testing.T) {
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
service, err := NewDealPusher(db, "https://api.node.glif.io", "", 1, 10)
service, err := NewDealPusher(db, testutil.TestLotusAPI, "", 1, 10)
require.NoError(t, err)
mockDealmaker := new(MockDealMaker)
service.dealMaker = mockDealmaker
Expand Down Expand Up @@ -418,7 +418,7 @@ func TestDealmakerService_Force(t *testing.T) {

func TestDealMakerService_MaxReplica(t *testing.T) {
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
service, err := NewDealPusher(db, "https://api.node.glif.io", "", 1, 1)
service, err := NewDealPusher(db, testutil.TestLotusAPI, "", 1, 1)
require.NoError(t, err)
mockDealmaker := new(MockDealMaker)
service.dealMaker = mockDealmaker
Expand Down Expand Up @@ -475,7 +475,7 @@ func TestDealMakerService_MaxReplica(t *testing.T) {

func TestDealMakerService_NewScheduleOneOff(t *testing.T) {
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
service, err := NewDealPusher(db, "https://api.node.glif.io", "", 1, 10)
service, err := NewDealPusher(db, testutil.TestLotusAPI, "", 1, 10)
require.NoError(t, err)
mockDealmaker := new(MockDealMaker)
service.dealMaker = mockDealmaker
Expand Down
3 changes: 2 additions & 1 deletion service/dealtracker/dealtracker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ func TestTrackDeal(t *testing.T) {
}

func TestRunOnce(t *testing.T) {
testutil.SkipIfNotExternalAPI(t)
testutil.All(t, func(ctx context.Context, t *testing.T, db *gorm.DB) {
err := db.Create(&model.Wallet{
ID: "t0100",
Expand Down Expand Up @@ -337,7 +338,7 @@ func TestRunOnce(t *testing.T) {
url, server := setupTestServerWithBody(t, string(body))
defer server.Close()
require.NoError(t, err)
tracker := NewDealTracker(db, time.Minute, url, "https://api.node.glif.io/", "", true)
tracker := NewDealTracker(db, time.Minute, url, testutil.TestLotusAPI, "", true)
err = tracker.runOnce(context.Background())
require.NoError(t, err)
var allDeals []model.Deal
Expand Down
11 changes: 6 additions & 5 deletions service/epochutil/epoch_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,40 +4,41 @@ import (
"context"
"testing"

"github.com/data-preservation-programs/singularity/util/testutil"
"github.com/stretchr/testify/require"
)

func TestDefaultValue(t *testing.T) {
err := Initialize(context.Background(), "https://api.node.glif.io/rpc/v0", "")
err := Initialize(context.Background(), testutil.TestLotusAPI, "")
require.NoError(t, err)
require.EqualValues(t, 1598306400, GenesisTimestamp)
}

func TestCalibNet(t *testing.T) {
// This test may fail when calibnet resets
err := Initialize(context.Background(), "https://api.calibration.node.glif.io/rpc/v0", "")
err := Initialize(context.Background(), "https://api.calibration.node.glif.io/rpc/v1", "")
require.NoError(t, err)
require.EqualValues(t, 1667326380, GenesisTimestamp)
}

func TestEpochToTime(t *testing.T) {
err := Initialize(context.Background(), "https://api.node.glif.io/rpc/v0", "")
err := Initialize(context.Background(), testutil.TestLotusAPI, "")
require.NoError(t, err)
require.EqualValues(t, 1598306400, GenesisTimestamp)
require.EqualValues(t, 1598306400, EpochToTime(0).Unix())
require.EqualValues(t, 1598306430, EpochToTime(1).Unix())
}

func TestUnixToEpoch(t *testing.T) {
err := Initialize(context.Background(), "https://api.node.glif.io/rpc/v0", "")
err := Initialize(context.Background(), testutil.TestLotusAPI, "")
require.NoError(t, err)
require.EqualValues(t, 1598306400, GenesisTimestamp)
require.EqualValues(t, 0, UnixToEpoch(1598306400))
require.EqualValues(t, 1, UnixToEpoch(1598306430))
}

func TestTimeToEpoch(t *testing.T) {
err := Initialize(context.Background(), "https://api.node.glif.io/rpc/v0", "")
err := Initialize(context.Background(), testutil.TestLotusAPI, "")
require.NoError(t, err)
require.EqualValues(t, 1598306400, GenesisTimestamp)
require.EqualValues(t, 0, TimeToEpoch(EpochToTime(0)))
Expand Down
14 changes: 14 additions & 0 deletions util/testutil/testutils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,20 @@ const TestWalletAddr = "f1fib3pv7jua2ockdugtz7viz3cyy6lkhh7rfx3sa"

const TestPrivateKeyHex = "7b2254797065223a22736563703235366b31222c22507269766174654b6579223a226b35507976337148327349586343595a58594f5775453149326e32554539436861556b6c4e36695a5763453d227d"

// TestLotusAPI is the Lotus API endpoint to use for tests
// Using /rpc/v1 (stable) instead of deprecated /rpc/v0
const TestLotusAPI = "https://api.node.glif.io/rpc/v1"

// SkipIfNotExternalAPI skips the test if SINGULARITY_TEST_EXTERNAL_API is not set
// Use this for tests that make external API calls (e.g., Lotus/Filecoin APIs)
// These are skipped by default because external APIs may be unreliable or rate-limited
func SkipIfNotExternalAPI(t *testing.T) {
t.Helper()
if os.Getenv("SINGULARITY_TEST_EXTERNAL_API") == "" {
t.Skip("Skipping external API test. Set SINGULARITY_TEST_EXTERNAL_API=true to run")
}
}

func EscapePath(p string) string {
return "'" + strings.ReplaceAll(p, `\`, `\\`) + "'"
}
Expand Down
7 changes: 5 additions & 2 deletions util/util_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"reflect"
"testing"

"github.com/data-preservation-programs/singularity/util/testutil"
"github.com/libp2p/go-libp2p/core/crypto"
"github.com/rjNemo/underscore"
"github.com/stretchr/testify/require"
Expand All @@ -23,9 +24,10 @@ func TestNextPowerOfTwo(t *testing.T) {
}

func TestNewLotusClient(t *testing.T) {
testutil.SkipIfNotExternalAPI(t)
for _, token := range []string{""} {
t.Run(token, func(t *testing.T) {
client := NewLotusClient("https://api.node.glif.io/", token)
client := NewLotusClient(testutil.TestLotusAPI, token)
resp, err := client.Call(context.Background(), "Filecoin.Version")
if token != "" {
require.Error(t, err)
Expand All @@ -39,7 +41,8 @@ func TestNewLotusClient(t *testing.T) {
}

func TestGetLotusHeadTime(t *testing.T) {
headTime, err := GetLotusHeadTime(context.Background(), "https://api.node.glif.io/", "")
testutil.SkipIfNotExternalAPI(t)
headTime, err := GetLotusHeadTime(context.Background(), testutil.TestLotusAPI, "")
require.NoError(t, err)
require.NotZero(t, headTime)
}
Expand Down