Further SDP refinement + some stop-gap for app support#5
Merged
Conversation
- Enhanced description with third-person voice and key search terms - Changed skill name from 'sdp' to 'spark-declarative-pipelines' - Reduced SKILL.md from 694 to 277 lines (under 500-line recommendation) - Created 7-advanced-configuration.md with all extra_settings details - Implements progressive disclosure pattern per Claude best practices
Collaborator
Author
|
This one's super low-touch, going to merge 👍 |
calreynolds
added a commit
that referenced
this pull request
Feb 12, 2026
Fix #1: Add comment explaining FastAPI routing intent (bare "fastapi" → python skill, "fastapi react" → APX). Add test case and ground truth for the edge case where both skills match. Fix #5: Change `str = None` to `Optional[str] = None` for all optional params in MCP tool wrappers (description, mode, deployment_id, name_contains). Fix #9: Remove misleading `DB_CONNECTION_STRING` valueFrom in Lakebase ground truth app.yaml. The code uses auto-injected PG* env vars, not DB_CONNECTION_STRING. Add explanatory note about Lakebase auto-injection. Nits: Add --server.headless true to SKILL.md Streamlit command for consistency with 3-frameworks.md and 4-deployment.md. Add comment in skills_manager.py explaining why APX and Python share the same tools. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.