-
Notifications
You must be signed in to change notification settings - Fork 154
Fix DBConnect support in VS Code #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 14 additions & 9 deletions
23
...te/templates/default-python/template/{{.project_name}}/src/{{.project_name}}/main.py.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,21 @@ | ||
| {{- /* | ||
| We use pyspark.sql rather than DatabricksSession.builder.getOrCreate() | ||
| for compatibility with older runtimes. With a new runtime, it's | ||
| equivalent to DatabricksSession.builder.getOrCreate(). | ||
| */ -}} | ||
| from pyspark.sql import SparkSession | ||
| from pyspark.sql import SparkSession, DataFrame | ||
|
|
||
| def get_taxis(): | ||
| spark = SparkSession.builder.getOrCreate() | ||
| def get_taxis(spark: SparkSession) -> DataFrame: | ||
| return spark.read.table("samples.nyctaxi.trips") | ||
|
|
||
|
|
||
| # Create a new Databricks Connect session. If this fails, | ||
| # check that you have configured Databricks Connect correctly. | ||
| # See https://docs.databricks.com/dev-tools/databricks-connect.html. | ||
| def get_spark() -> SparkSession: | ||
| try: | ||
| from databricks.connect import DatabricksSession | ||
| return DatabricksSession.builder.getOrCreate() | ||
| except ImportError: | ||
| return SparkSession.builder.getOrCreate() | ||
|
|
||
| def main(): | ||
| get_taxis().show(5) | ||
| get_taxis(get_spark()).show(5) | ||
|
|
||
| if __name__ == '__main__': | ||
| main() | ||
19 changes: 2 additions & 17 deletions
19
libs/template/templates/default-python/template/{{.project_name}}/tests/main_test.py.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,6 @@ | ||
| from databricks.connect import DatabricksSession | ||
| from pyspark.sql import SparkSession | ||
| from {{.project_name}} import main | ||
| from {{.project_name}}.main import get_taxis, get_spark | ||
|
|
||
| # Create a new Databricks Connect session. If this fails, | ||
| # check that you have configured Databricks Connect correctly. | ||
| # See https://docs.databricks.com/dev-tools/databricks-connect.html. | ||
| {{/* | ||
| The below works around a problematic error message from Databricks Connect. | ||
| The standard SparkSession is supported in all configurations (workspace, IDE, | ||
| all runtime versions, CLI). But on the CLI it currently gives a confusing | ||
| error message if SPARK_REMOTE is not set. We can't directly use | ||
| DatabricksSession.builder in main.py, so we're re-assigning it here so | ||
| everything works out of the box, even for CLI users who don't set SPARK_REMOTE. | ||
| */}} | ||
| SparkSession.builder = DatabricksSession.builder | ||
| SparkSession.builder.getOrCreate() | ||
|
|
||
| def test_main(): | ||
| taxis = main.get_taxis() | ||
| taxis = get_taxis(get_spark()) | ||
| assert taxis.count() > 5 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really doesn't seem like it should be how we recommend customers write their code...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but until we have something better I'd rather be explicit and verbose than not supporting old DBRs or hiding it in non-standard libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does seem like a very specific factory pattern we want users to follow. How about moving it inside the main function and not having the get_spark function? That should make it very clear that this is not intended to be used everywhere and is here to only enable per file runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct to understand that the only case that
DatabricksSession.builder.getOrCreate()will fail is if the user is targeting this at DBR <13?