-
Notifications
You must be signed in to change notification settings - Fork 154
Upgrade Go SDK to 0.44.0 #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Upgrade Go SDK to 0.44.0 #1679
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7b73596
Upgrade Go SDK to 0.44.0
andrewnester 346088c
fixed tests and groups
andrewnester fb951fc
fixes
andrewnester bebfd12
Fix workspace client prompt test
pietern d8e62cc
Remove trailing ? from URL path
pietern 4a07615
tenant id for account test
andrewnester File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 7437dabb9dadee402c1fc060df4c1ce8cc5369f0 | ||
| f98c07f9c71f579de65d2587bb0292f83d10e55d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,7 +78,7 @@ func (l *UpdateTracker) Events(ctx context.Context) ([]ProgressEvent, error) { | |
| } | ||
|
|
||
| // we only check the most recent 100 events for progress | ||
| response, err := l.w.Pipelines.Impl().ListPipelineEvents(ctx, pipelines.ListPipelineEventsRequest{ | ||
| events, err := l.w.Pipelines.ListPipelineEventsAll(ctx, pipelines.ListPipelineEventsRequest{ | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| PipelineId: l.PipelineId, | ||
| MaxResults: 100, | ||
| Filter: filter, | ||
|
|
@@ -89,8 +89,8 @@ func (l *UpdateTracker) Events(ctx context.Context) ([]ProgressEvent, error) { | |
|
|
||
| result := make([]ProgressEvent, 0) | ||
| // we iterate in reverse to return events in chronological order | ||
| for i := len(response.Events) - 1; i >= 0; i-- { | ||
| event := response.Events[i] | ||
| for i := len(events) - 1; i >= 0; i-- { | ||
| event := events[i] | ||
| // filter to only include update_progress and flow_progress events | ||
| if event.EventType == "flow_progress" || event.EventType == "update_progress" { | ||
| result = append(result, ProgressEvent(event)) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implis not exposed from Go SDK anymore