Add a test for sync root outside of git root#2202
Merged
Conversation
denik
requested review from
andrewnester,
pietern and
shreyas-goenka
as code owners
| @@ -0,0 +1,6 @@ | |||
| # This should error, we do not allow syncroot outside of git repo | |||
Contributor
There was a problem hiding this comment.
Is there a reason why we won't allow it? I can imagine the case when users want to sync build artifacts which are not part of the git repo as well
Contributor
Author
There was a problem hiding this comment.
The idea here is that if people use git, they want reproducibility, so sources should be in git.
build artifacts can be placed inside git root and gitignored.
denik
force-pushed
the
denik/sync-root-test
branch
from
5f054cb to
f91be8a
Compare
pietern
approved these changes
Jan 22, 2025
| r.appendLiteral(old, new) | ||
| } | ||
|
|
||
| func trimQuotes(s string) string { |
Contributor
There was a problem hiding this comment.
Why is this needed?
If we only care about quoting strings, you can look at fmt.Sprintf with %q.
Contributor
Author
There was a problem hiding this comment.
I care about strings inside JSON that might have been concatenated with others, e.g. xy becomes "XY" in json. Now I need to replace x -> X.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix replacer to work with this test and on Windows: