Move artifacts validation to initialize phase; simplify

NEXT_CHANGELOG.md

@@ -6,4 +6,6 @@
 
 ### Bundles
 
+* Processing 'artifacts' section is now done in "bundle validate" (adding defaults, inferring "build", asserting required fields) ([#2526])(https://github.com/databricks/cli/pull/2526))
+
 ### API Changes

acceptance/bundle/artifacts/build_and_files/databricks.yml

@@ -0,0 +1,9 @@
+bundle:
+  name: build_and_files
+
+artifacts:
+  custom:
+    build: touch built.txt
+    files:
+      # this file does not exist yet, will be generated by build command
+      - source: built.txt

acceptance/bundle/artifacts/build_and_files/output.txt

@@ -0,0 +1,11 @@
+{
+  "custom": {
+    "build": "touch built.txt",
+    "files": [
+      {
+        "source": "[TMPDIR]/built.txt"
+      }
+    ],
+    "path": "[TMPDIR]"
+  }
+}

acceptance/bundle/artifacts/build_and_files/script

@@ -0,0 +1 @@
+$CLI bundle validate -o json | jq .artifacts

acceptance/bundle/artifacts/build_and_files/test.toml

@@ -0,0 +1,5 @@
+RecordRequests = false
+
+[[Repls]]
+Old = '\\\\'
+New = '/'

acceptance/bundle/artifacts/globs_in_files/databricks.yml

@@ -0,0 +1,8 @@
+bundle:
+  name: expand_globs
+
+artifacts:
+  test:
+    files:
+      - source: a*.txt
+      - source: subdir/*.txt

acceptance/bundle/artifacts/globs_in_files/output.txt

@@ -0,0 +1,61 @@
+
+>>> [CLI] bundle validate -o json
+Error: a*.txt: no matching files
+  at artifacts.test.files[0].source
+  in databricks.yml:7:17
+
+Error: subdir/*.txt: no matching files
+  at artifacts.test.files[1].source
+  in databricks.yml:8:17
+
+
+Exit code: 1
+{
+  "test": {
+    "files": [
+      {
+        "source": "a*.txt"
+      },
+      {
+        "source": "subdir/*.txt"
+      }
+    ]
+  }
+}
+
+>>> [CLI] bundle validate -o json
+Error: subdir/*.txt: no matching files
+  at artifacts.test.files[1].source
+  in databricks.yml:8:17
+
+
+Exit code: 1
+{
+  "test": {
+    "files": [
+      {
+        "source": "a*.txt"
+      },
+      {
+        "source": "subdir/*.txt"
+      }
+    ]
+  }
+}
+
+>>> [CLI] bundle validate -o json
+{
+  "test": {
+    "files": [
+      {
+        "source": "a1.txt"
+      },
+      {
+        "source": "a2.txt"
+      },
+      {
+        "source": "subdir/hello.txt"
+      }
+    ]
+  }
+}

acceptance/bundle/artifacts/globs_in_files/script

@@ -0,0 +1,12 @@
+errcode trace $CLI bundle validate -o json | jq .artifacts
+
+touch a1.txt
+touch a2.txt
+
+errcode trace $CLI bundle validate -o json | jq .artifacts
+
+mkdir -p subdir
+touch subdir/hello.txt
+errcode trace $CLI bundle validate -o json | jq .artifacts
+
+rm -fr a1.txt a2.txt subdir

acceptance/bundle/artifacts/globs_in_files/test.toml

@@ -0,0 +1,5 @@
+RecordRequests = false
+
+[[Repls]]
+Old = '\\\\'
+New = '/'

acceptance/bundle/artifacts/globs_invalid/databricks.yml

@@ -0,0 +1,10 @@
+bundle:
+  name: expand_globs
+
+artifacts:
+  test:
+    files:
+      - source: "a[.txt"
+      - source: "./a[.txt"
+      - source: "../a[.txt"
+      - source: "subdir/a[.txt"

acceptance/bundle/artifacts/globs_invalid/output.txt

@@ -0,0 +1,38 @@
+
+>>> [CLI] bundle validate -o json
+Error: a[.txt: syntax error in pattern
+  at artifacts.test.files[0].source
+  in databricks.yml:7:17
+
+Error: ./a[.txt: syntax error in pattern
+  at artifacts.test.files[1].source
+  in databricks.yml:8:17
+
+Error: ../a[.txt: syntax error in pattern
+  at artifacts.test.files[2].source
+  in databricks.yml:9:17
+
+Error: subdir/a[.txt: syntax error in pattern
+  at artifacts.test.files[3].source
+  in databricks.yml:10:17
+
+
+Exit code: 1
+{
+  "test": {
+    "files": [
+      {
+        "source": "a[.txt"
+      },
+      {
+        "source": "./a[.txt"
+      },
+      {
+        "source": "../a[.txt"
+      },
+      {
+        "source": "subdir/a[.txt"
+      }
+    ]
+  }
+}

acceptance/bundle/artifacts/globs_invalid/script

@@ -0,0 +1 @@
+errcode trace $CLI bundle validate -o json | jq .artifacts

acceptance/bundle/artifacts/globs_invalid/test.toml

@@ -0,0 +1 @@
+RecordRequests = false

acceptance/bundle/debug/out.stderr.txt

@@ -60,6 +60,8 @@
 10:07:59 Debug: Apply pid=12345 mutator=ConfigureWSFS
 10:07:59 Debug: Apply pid=12345 mutator=TranslatePaths
 10:07:59 Debug: Apply pid=12345 mutator=PythonWrapperWarning
+10:07:59 Debug: Apply pid=12345 mutator=artifacts.Prepare
+10:07:59 Info: No local tasks in databricks.yml config, skipping auto detect pid=12345 mutator=artifacts.Prepare
 10:07:59 Debug: Apply pid=12345 mutator=apps.Validate
 10:07:59 Debug: Apply pid=12345 mutator=ValidateSharedRootPermissions
 10:07:59 Debug: Apply pid=12345 mutator=ApplyBundlePermissions