Skip to content

Make apply_presets.go more resilient and consistent #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 1 commit into from
Apr 25, 2025
Merged

Make apply_presets.go more resilient and consistent #2777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 25 additions & 19 deletions acceptance/bundle/validate/empty_resources/empty_dict/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,51 @@

=== resources.jobs.rname ===
Error: job rname is not defined

{
"jobs": {
"rname": {}
"rname": {
"deployment": {
"kind": "BUNDLE",
"metadata_file_path": "/Workspace/Users/[USERNAME]/.bundle/BUNDLE/default/state/metadata.json"
},
"edit_mode": "UI_LOCKED",
"format": "MULTI_TASK",
"permissions": [],
"queue": {
"enabled": true
}
}
}
}

=== resources.pipelines.rname ===
Error: pipeline rname is not defined

{
"pipelines": {
"rname": {}
"rname": {
"permissions": []
}
}
}

=== resources.models.rname ===
Error: model rname is not defined

{
"models": {
"rname": {}
"rname": {
"permissions": []
}
}
}

=== resources.experiments.rname ===
Error: experiment rname is not defined

{
"experiments": {
"rname": {}
"rname": {
"name": ".",
"permissions": []
}
}
}

=== resources.registered_models.rname ===
Error: registered model rname is not defined

{
"registered_models": {
"rname": {}
Expand All @@ -52,8 +60,6 @@ Error: registered model rname is not defined
}

=== resources.schemas.rname ===
Error: schema rname is not defined

{
"schemas": {
"rname": {}
Expand All @@ -70,11 +76,11 @@ Error: schema rname is not defined
}

=== resources.clusters.rname ===
Error: cluster rname is not defined

{
"clusters": {
"rname": {}
"rname": {
"custom_tags": {}
}
}
}

Expand Down
44 changes: 25 additions & 19 deletions acceptance/bundle/validate/empty_resources/with_grants/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,20 @@ Warning: unknown field: grants
at resources.jobs.rname
in databricks.yml:7:7

Error: job rname is not defined

{
"jobs": {
"rname": {}
"rname": {
"deployment": {
"kind": "BUNDLE",
"metadata_file_path": "/Workspace/Users/[USERNAME]/.bundle/BUNDLE/default/state/metadata.json"
},
"edit_mode": "UI_LOCKED",
"format": "MULTI_TASK",
"permissions": [],
"queue": {
"enabled": true
}
}
}
}

Expand All @@ -17,11 +26,11 @@ Warning: unknown field: grants
at resources.pipelines.rname
in databricks.yml:7:7

Error: pipeline rname is not defined

{
"pipelines": {
"rname": {}
"rname": {
"permissions": []
}
}
}

Expand All @@ -30,11 +39,11 @@ Warning: unknown field: grants
at resources.models.rname
in databricks.yml:7:7

Error: model rname is not defined

{
"models": {
"rname": {}
"rname": {
"permissions": []
}
}
}

Expand All @@ -43,17 +52,16 @@ Warning: unknown field: grants
at resources.experiments.rname
in databricks.yml:7:7

Error: experiment rname is not defined

{
"experiments": {
"rname": {}
"rname": {
"name": ".",
"permissions": []
}
}
}

=== resources.registered_models.rname ===
Error: registered model rname is not defined

{
"registered_models": {
"rname": {
Expand All @@ -74,8 +82,6 @@ Warning: unknown field: grants
}

=== resources.schemas.rname ===
Error: schema rname is not defined

{
"schemas": {
"rname": {
Expand All @@ -99,11 +105,11 @@ Warning: unknown field: grants
at resources.clusters.rname
in databricks.yml:7:7

Error: cluster rname is not defined

{
"clusters": {
"rname": {}
"rname": {
"custom_tags": {}
}
}
}

Expand Down
27 changes: 12 additions & 15 deletions acceptance/bundle/validate/empty_resources/with_permissions/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,23 @@

=== resources.jobs.rname ===
Error: job rname is not defined

{
"jobs": {
"rname": {
"permissions": []
"deployment": {
"kind": "BUNDLE",
"metadata_file_path": "/Workspace/Users/[USERNAME]/.bundle/BUNDLE/default/state/metadata.json"
},
"edit_mode": "UI_LOCKED",
"format": "MULTI_TASK",
"permissions": [],
"queue": {
"enabled": true
}
}
}
}

=== resources.pipelines.rname ===
Error: pipeline rname is not defined

{
"pipelines": {
"rname": {
Expand All @@ -22,8 +27,6 @@ Error: pipeline rname is not defined
}

=== resources.models.rname ===
Error: model rname is not defined

{
"models": {
"rname": {
Expand All @@ -33,11 +36,10 @@ Error: model rname is not defined
}

=== resources.experiments.rname ===
Error: experiment rname is not defined

{
"experiments": {
"rname": {
"name": ".",
Copy link
Copy Markdown
Contributor Author

@denik denik Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it makes sense for experiment to have name="." @pietern @lennartkats-db

Related: #1490

Copy link
Copy Markdown
Contributor

@pietern pietern Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely because of a path.Clean call. The name must be a valid filename (or path, don't recall).

"permissions": []
}
}
Expand All @@ -48,8 +50,6 @@ Warning: unknown field: permissions
at resources.registered_models.rname
in databricks.yml:7:7

Error: registered model rname is not defined

{
"registered_models": {
"rname": {}
Expand All @@ -72,8 +72,6 @@ Warning: unknown field: permissions
at resources.schemas.rname
in databricks.yml:7:7

Error: schema rname is not defined

{
"schemas": {
"rname": {}
Expand All @@ -94,11 +92,10 @@ Warning: unknown field: permissions
}

=== resources.clusters.rname ===
Error: cluster rname is not defined

{
"clusters": {
"rname": {
"custom_tags": {},
"permissions": []
}
}
Expand Down
Loading
Loading