Skip to content

Apply presets before applying defaults #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 1 commit into from
Apr 25, 2025
Merged

Apply presets before applying defaults #2778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bundle/config/mutator/resourcemutator/resource_mutator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ func applyInitializeMutators(ctx context.Context, b *bundle.Bundle) diag.Diagnos
// OR corresponding fields on ForEachTask if that is present
// Overrides job compute settings with a specified cluster ID for development or testing
OverrideCompute(),

// ApplyPresets should have more priority than defaults below, so it should be run first
ApplyPresets(),
)

if diags.HasError() {
Expand All @@ -58,8 +61,6 @@ func applyInitializeMutators(ctx context.Context, b *bundle.Bundle) diag.Diagnos
}

diags = diags.Extend(bundle.ApplySeq(ctx, b,
ApplyPresets(),

// Reads (typed): b.Config.Resources.Jobs (checks job configurations)
// Updates (typed): b.Config.Resources.Jobs[].Queue (sets Queue.Enabled to true for jobs without queue settings)
// Enable queueing for jobs by default, following the behavior from API 2.2+.
Expand Down
Loading