Return error when bundle run fails to start a job#2843
Merged
shreyas-goenka merged 1 commit intomainfrom May 12, 2025
Merged
Conversation
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik and
pietern
as code owners
pietern
approved these changes
May 12, 2025
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Are there more instances like this in the codebase?
Contributor
Author
shreyas-goenka
added a commit
that referenced
this pull request
May 12, 2025
## Why Minor UX improvement. Provides users with context for why searching for *.py files failed for them. Prompted by: #2843 (review) ## Tests Not tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We overlooked returning the error itself when starting a job run. This PR fixes that.