When collecting libraries, convert them to absolute path#2986
Closed
When collecting libraries, convert them to absolute path#2986
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
force-pushed
the
denik/artifacts-collect
branch
from
7574095 to
5748149
Compare
pietern
reviewed
Jun 4, 2025
| if !filepath.IsAbs(source) { | ||
| source = filepath.Join(b.SyncRootPath, source) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
These cannot be absolute. If you use an absolute path in the whl or jar references, then IsLibraryLocal returns false because we treat them as remote absolute paths, e.g. /Workspace/Jars/foo.jar.
| if !filepath.IsAbs(source) { | ||
| source = filepath.Join(b.BundleRootPath, source) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
These paths are already absolute. Transformation is done here:
cli/bundle/artifacts/prepare.go
Lines 50 to 56 in 33106ba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise if some paths are relative, they could be registered more than once.
Discovered while working on #2982 however not sure if it's a bug in practice or there is some other code that converts those paths to absolute.
Also wrap filepath.Join with IsAbs check, it does not do that automatically.