Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
force-pushed
the
denik/acc-sort-tasks
branch
from
0646e95 to
8cbd777
Compare
pietern
reviewed
Jul 9, 2025
| // However, if we don't sort we have a difference between direct and TF and between configs in | ||
| // "bundle validate" and configs sent to backend. | ||
| sort.Strings(keys) | ||
|
|
Contributor
There was a problem hiding this comment.
Can you push this into the call site? Then it is specific to job tasks + job clusters.
pietern
approved these changes
Jul 9, 2025
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Worth calling out in the changelog?
I doubt it, but hypothetically someone could refer to another tasks' parameters by index.
Collaborator
296 failing tests:
|
denik
force-pushed
the
denik/acc-sort-tasks
branch
from
0852307 to
ea14188
Compare
denik
force-pushed
the
denik/acc-sort-tasks
branch
from
3573b95 to
7523673
Compare
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Jul 10, 2025
## Release v0.259.0 ### Notable Changes * Add support for arbitrary scripts in DABs. Users can now define scripts in their bundle configuration. These scripts automatically inherit the bundle's credentials for authentication. They can be invoked with the `bundle run` command. ([#2813](#2813)) * Error when the absolute path to `databricks.yml` contains a glob character. These are: `*`, `?`, `[`, `]` and `^`. If the path to the `databricks.yml` file on your local filesystem contains one of these characters, that could lead to incorrect computation of glob patterns for the `includes` block and might cause resources to be deleted. After this patch users will not be at risk for unexpected deletions due to this issue. ([#3096](#3096)) * Diagnostics messages are no longer buffered to be printed at the end of command, flushed after every mutator ([#3175](#3175)) * Diagnostics are now always rendered with forward slashes in file paths, even on Windows ([#3175](#3175)) * "bundle summary" now prints diagnostics to stderr instead of stdout in text output mode ([#3175](#3175)) * "bundle summary" no longer prints recommendations, it will only prints warnings and errors ([#3175](#3175)) ### Bundles * Fix default search location for whl artifacts ([#3184](#3184)). This was a regression introduced in 0.255.0. * The job tasks are now sorted by task key in "bundle validate/summary" output ([#3212](#3212))
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 27, 2025
…s to ignore order (#4014) ## Changes - Extend structpath to support [key=‘value’] syntax. - Extend structdiff with extra parameter that maps path to keyFunc which is a function that returns key/value pair for a given slice element. They pair is used to identify the slice element. - Use this functionality on permissions resource in direct to solve drift due to backend reordering permissions. ## Why - Prevent remote drift due to backend reordering slice elements. - Make diffs more readable / precise. This is an alternative to always sorting the input, which destroys the references ($resources.jobs.foo.tasks[1] is not valid today because of sorting). In a follow up PR I’ll revert job tasks sorting #3212 and implement KeyedSlices instead.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
## Changes Configure "task_key" as a way to identify tasks in jobs. Builds on top of #4014 ## Why Makes diffs more precise. Ignores reordering of slice without need of sorting (#3212). Note, we still sort, this is to be reverted in separate PR. ## Tests Existing tests. New test that reorders tasks locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Sort job tasks by task key.
Why
This is what terraform provider does before deployment. Doing so earlier exposes this changes to the user in bundle validate and make it possible to match requests done by TF and direct backends.
https://github.com/databricks/terraform-provider-databricks/blob/0a932c2/jobs/resource_job.go#L343
Tests
New tests enabled on direct backend.