Detect duplicate identifiers in bundle config#332
Merged
shreyas-goenka merged 9 commits intomainfrom Apr 17, 2023
Merged
Conversation
pietern
reviewed
Apr 14, 2023
pietern
approved these changes
Apr 14, 2023
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Nice work!
Could you move testdata to bundle/tests and add a black-box test there as well? It can load the bundle at the path and verify an error comes back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds checks during bundle config load and merge to error out if there are duplicate keys for resource definitions
Tests
Using unit tests and manually