Reject use of fmt.Printf under cmd/

[pietern]

Changes

Reject directly writing to global stdout/stderr.

The "forbidigo" linter includes this rule by default.

Also see https://golangci-lint.run/docs/linters/configuration/#forbidigo

Why

The CLI uses Cobra and should therefore use cmd.OutOrStdout() and friends.

Saw this here: #3546 (comment)

[denik]

The CLI uses Cobra and should therefore use cmd.OutOrStdout() and friends.

Could you expand this a bit? What's the advantage of extra indirection? What's the case for when it is useful?

[denik]

can this be enabled on libs? That's where you don't want print to stdout/stderr typically (outside of debugging).

[pietern]

It can, but it adds a few more failures. I'd like to keep this small/focused.

[eng-dev-ecosystem-bot]

Run: 17551339165

	Env	✅​pass	🙈​skip
✅​	aws linux	308	519
✅​	aws windows	309	518
✅​	aws-ucws linux	420	417
✅​	aws-ucws windows	421	416
✅​	azure linux	308	518
✅​	azure windows	309	517
✅​	azure-ucws linux	420	416
✅​	azure-ucws windows	421	415
✅​	gcp linux	307	520
✅​	gcp windows	308	519

[pietern]

The advantage of indirection is that you can construct a command, run it, and capture the output from within Go.

Granted, it has become less relevant now that we write more acceptance tests.

[denik]

The advantage of indirection is that you can construct a command, run it, and capture the output from within Go.

Granted, it has become less relevant now that we write more acceptance tests.

ah I see, so it's for testing, potentially. That's valid.