Added secrets resource support to DABs#4034
Added secrets resource support to DABs#4034varundeepsaini wants to merge 1 commit intodatabricks:mainfrom
Conversation
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
hey @andrewnester |
| } | ||
|
|
||
| // Read back the secret to get remote state | ||
| return r.DoRead(ctx, id) |
There was a problem hiding this comment.
should just return nil there, the framework will call DoRead() if it's needed. Same for DoCreate().
| @@ -0,0 +1,111 @@ | |||
| package dresources | |||
There was a problem hiding this comment.
Oh, didnt realise it is being worked on, better that I don't work on this feature
do you guys have anything else that i can pick up that you are not actively working on
|
@varundeepsaini and @denik - Was this closed to soon? Ref #3689 - I would really love to be able to put a secret within a secret scope, as mentioned in the description of this PR. Can't see that #3886 solves this. |
|
@johalnes Can you please consider creating a new issue for adding support for secrets. We are unlikely to add it anytime soon because secret values are sensitive and need to be modelled appropriately. But a trackable issue can help us guage interest and then appropriately prioritize this. |
@shreyas-goenka Isn't the issue I mentioned above enough? That is #3689 ? |
Changes
Add
secretsandsecret_scopesas bundle resourcesWhy
Closes #3689
Users need to manage secrets alongside their jobs/pipelines in bundles rather than creating them manually.
Tests