fix: Sort dependsOn to avoid diff#4363
Closed
orslow wants to merge 1 commit into
Closed
Conversation
orslow
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
I love it |
Contributor
|
Thanks for raising the PR! For contributing to Databricks CLI we require users to sign CLA, if that's something you are willing to do, please drop an email with a request to dabs-feedback@databricks.com |
Contributor
|
This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled. |
Contributor
|
FYI, there is fix for this for direct engine: #4990 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Sort depends_on array within each job task by task_key to ensure consistent ordering.
Why
The Databricks API returns depends_on sorted by task_key. When the local configuration has depends_on not sorted alphabetically, Terraform detects a diff even though there are no actual changes. This causes unnecessary "change" actions in bundle plan output.
Tests
Built the CLI locally and compared bundle plan output before and after the change, verified that jobs with depends_on in non-alphabetical order no longer show false diffs.