Prompt for workspace ID when workspace list fails#4859
Merged
simonfaltum merged 3 commits intomainfrom Mar 30, 2026
Merged
Conversation
When `databricks auth login` cannot fetch the workspace list (e.g. when the user has no account-level permissions), instead of silently continuing without a workspace, prompt the user to manually enter a workspace ID. Empty input skips workspace selection as before. Co-authored-by: Isaac
hectorcast-db
requested review from
andrewnester,
anton-107,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: low Eligible reviewersBased on CODEOWNERS, these people or teams could also review: @andrewnester, @anton-107, @denik, @shreyas-goenka Suggestions based on git history of 1 changed files (1 scored). See CODEOWNERS for path-specific ownership rules. |
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 53f7181
17 interesting tests: 10 SKIP, 7 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
The warning was noisy for users without account-level access since the fallback to prompting for workspace ID is expected behavior. Co-authored-by: Isaac
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
approved these changes
Mar 30, 2026
simonfaltum
reviewed
Mar 30, 2026
Member
simonfaltum
left a comment
simonfaltum
left a comment
There was a problem hiding this comment.
Review Swarm: Isaac + Cursor | 2 rounds
Verdict: Not ready yet (1 Critical)
1 Critical | 0 Major | 3 Nit | 1 Suggestion
[Nit] Stale docstring on promptForWorkspaceSelection (Found by: Cursor, Confirmed by: Isaac)
The comment block above promptForWorkspaceSelection (around line 700) says errors are returned to the caller for logging. This PR changes that behavior: the Workspaces.List error is now logged internally and the function falls back to manual input. Consider updating the comment.
[Nit] Warning message could mention alternatives (Found by: Isaac)
Low priority. The subsequent prompt makes the next step obvious. Could optionally mention --workspace-id for scripted usage.
[Suggestion] Add unit test for the fallback path (Found by: Both)
No automated coverage for the new fallback behavior. Test infrastructure already exists (e.g. cmdio.SetupTest for canned input). A test that mocks a failing Workspaces.List and verifies the manual prompt fires would be valuable.
simonfaltum
approved these changes
Mar 30, 2026
Collaborator
|
Commit: cbb703c
52 interesting tests: 23 RECOVERED, 17 flaky, 7 FAIL, 3 KNOWN, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
databricks auth loginfails to fetch the workspace list (e.g. user lacks account-level permissions), prompt the user to manually enter a workspace ID instead of logging and error and skipping the workspace selection.Manual test
Test plan
This pull request was AI-assisted by Isaac.