Fix creating local filer at the root of a windows file system#487
Closed
shreyas-goenka wants to merge 15 commits intomainfrom
Closed
Fix creating local filer at the root of a windows file system#487shreyas-goenka wants to merge 15 commits intomainfrom
shreyas-goenka wants to merge 15 commits intomainfrom
Conversation
shreyas-goenka
changed the title
pietern
approved these changes
Jun 15, 2023
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Please add a tiny unit test for this.
Can be:
- Skip unless Windows
- Get a TempDir
- Create filer on /
- Assert stat on TempDir succeeds
Contributor
Author
|
integration tests pass |
Contributor
Author
|
Not a complete solution yet |
pietern
requested changes
Jun 19, 2023
| } | ||
| return &LocalClient{ | ||
| root: NewRootPath(root), | ||
| root: NewUnixRootPath(root), |
Contributor
There was a problem hiding this comment.
It's still a windows path if the specified path is not equal to /, the name is confusing.
Since you have a UnixRootPath, please add a WindowsRootPath that uses filepath.Join instead of path.Join and includes the root check in Join itself. Then there is no need for a NopRootPath and we always end up picking the Windows one when running on Windows, regardless of the specified root.
Contributor
Author
|
solved by #506 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Allows filer to be created at root of a windows file system
Tests
Manually