acceptance: clean up vector_search_endpoints min_qps tests#5046
Merged
Conversation
Address review nits on #4887: - update/min_qps: drop redundant `--keep` + manual `rm` pair in `print_requests()` — `print_requests.py` already deletes `out.requests.txt` when `--keep` is omitted. - drift/min_qps: record `bundle plan --output json` to pin down that `min_qps` is the only field detected as changed (old=1, new=1, remote=5), not just the summary line. Co-authored-by: Isaac
denik
approved these changes
Apr 21, 2026
denik
pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Address review nits on #4887: - **`update/min_qps/script`**: drop redundant `--keep` + manual `rm` pair in `print_requests()`. `print_requests.py` already deletes `out.requests.txt` when `--keep` is omitted, so the pair was a no-op. ([thread](#4887 (comment))) - **`drift/min_qps/script`**: record `bundle plan --output json` alongside the existing `contains.py` summary check, so the test pins down that `min_qps` is the *only* field detected as changed (old=1, new=1, remote=5), not just the overall count. ([thread](#4887 (comment))) Not in this PR: the [`recreated_same_name` badness thread](#4887 (comment)) — that requires real behavior change (storing `endpoint_uuid` in state and comparing it via `OverrideChangeDesc`, similar to `dashboards.go`'s etag pattern), so it'll get its own follow-up PR. ## Tests - `go test ./acceptance -run TestAccept/bundle/resources/vector_search_endpoints/update/min_qps` - `go test ./acceptance -run TestAccept/bundle/resources/vector_search_endpoints/drift/min_qps`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Address review nits on #4887:
update/min_qps/script: drop redundant--keep+ manualrmpair inprint_requests().print_requests.pyalready deletesout.requests.txtwhen--keepis omitted, so the pair was a no-op. (thread)drift/min_qps/script: recordbundle plan --output jsonalongside the existingcontains.pysummary check, so the test pins down thatmin_qpsis the only field detected as changed (old=1, new=1, remote=5), not just the overall count. (thread)Not in this PR: the
recreated_same_namebadness thread — that requires real behavior change (storingendpoint_uuidin state and comparing it viaOverrideChangeDesc, similar todashboards.go's etag pattern), so it'll get its own follow-up PR.Tests
go test ./acceptance -run TestAccept/bundle/resources/vector_search_endpoints/update/min_qpsgo test ./acceptance -run TestAccept/bundle/resources/vector_search_endpoints/drift/min_qps