ci: catch new untracked files after running tests#5412
Merged
Conversation
PR #5370 added the designer_notebook test directory but omitted the generated out.test.toml. The acceptance runner writes this file as a side effect of test discovery and explicitly excludes it from output comparison, so a missing copy never fails a test. Regenerated here. Co-authored-by: Isaac
The test job already ran 'git diff --exit-code' after the suite, but a plain 'git diff' ignores untracked files. That is how a missing out.test.toml slipped through CI. Register untracked files with intent-to-add first so new files are reported too; .gitignore'd test artifacts are unaffected. Co-authored-by: Isaac
andrewnester
approved these changes
Jun 2, 2026
denik
approved these changes
Jun 2, 2026
Collaborator
|
Commit: fbbee16 |
Collaborator
|
Commit: ad37ce2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
designer_notebookacceptance test (added in #5370) was missing its generatedout.test.toml. The file is written as a side effect of test discovery and explicitly excluded from output comparison, so a missing copy never fails a test — and the post-testgit diff --exit-codeguard didn't catch it either, because plaingit diffignores untracked files. The result: the file silently regenerated as an untracked change in every worktree that ran the acceptance suite.This adds the missing
out.test.tomland fixes the CI guard to register untracked files withgit add --intent-to-add .before diffing, so any new file appearing after a test run now fails the build. Gitignored test artifacts are unaffected, since intent-to-add respects.gitignore.This pull request and its description were written by Isaac.