Skip to content

Use clearer error message when no interpolation value is found. #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyas-goenka merged 2 commits into from
Sep 11, 2023
Merged

Use clearer error message when no interpolation value is found. #764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4e72a0
Use clearer error message when no interpolation value is found.
shreyas-goenka Sep 11, 2023
ccc27c2
-
shreyas-goenka Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundle/config/interpolation/interpolation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func (a *accumulator) Resolve(path string, seenPaths []string, fns ...LookupFunc
// fetch the string node to resolve
field, ok := a.strings[path]
if !ok {
return fmt.Errorf("could not resolve reference %s", path)
return fmt.Errorf("no value found for interpolation reference: ${%s}", path)
}

// return early if the string field has no variables to interpolate
Expand Down
2 changes: 1 addition & 1 deletion bundle/config/interpolation/interpolation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,5 +247,5 @@ func TestInterpolationInvalidVariableReference(t *testing.T) {
}

err := expand(&config)
assert.ErrorContains(t, err, "could not resolve reference vars.foo")
assert.ErrorContains(t, err, "no value found for interpolation reference: ${vars.foo}")
}