Skip to content
This repository was archived by the owner on Jun 25, 2026. It is now read-only.

Remove methods calling into DBFS testing endpoints#510

Merged
pietern merged 1 commit into
databricks:mainfrom
pietern:dbfs-testing
Jul 11, 2022
Merged

Remove methods calling into DBFS testing endpoints#510
pietern merged 1 commit into
databricks:mainfrom
pietern:dbfs-testing

Conversation

@pietern

@pietern pietern commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

Closes #509.

@pietern pietern requested a review from nfx July 5, 2022 12:30
@pietern

pietern commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

Note: this should fail the new compatibility test because it removes methods. Because that's intentional here, we can ignore that failure (as long as its output indicates we're only removing these methods).

@codecov-commenter

codecov-commenter commented Jul 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #510 (80002a0) into main (0b6a78e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage   61.08%   61.08%           
=======================================
  Files          55       55           
  Lines        4662     4662           
=======================================
  Hits         2848     2848           
  Misses       1814     1814           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b6a78e...80002a0. Read the comment docs.

@pietern

pietern commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

Output of the compatibility test:

Removed functions:
 * databricks_cli.sdk.service.DbfsService.add_block_test
 * databricks_cli.sdk.service.DbfsService.close_test
 * databricks_cli.sdk.service.DbfsService.create_test
 * databricks_cli.sdk.service.DbfsService.delete_test
 * databricks_cli.sdk.service.DbfsService.get_status_test
 * databricks_cli.sdk.service.DbfsService.list_test
 * databricks_cli.sdk.service.DbfsService.mkdirs_test
 * databricks_cli.sdk.service.DbfsService.move_test
 * databricks_cli.sdk.service.DbfsService.put_test
 * databricks_cli.sdk.service.DbfsService.read_test

@pietern pietern merged commit 4647753 into databricks:main Jul 11, 2022
@pietern pietern deleted the dbfs-testing branch July 11, 2022 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove methods calling into DBFS testing endpoints

3 participants