Skip to content
This repository was archived by the owner on Jun 25, 2026. It is now read-only.

Add missing fields to JobsService#614

Merged
pietern merged 1 commit into
mainfrom
jobs-missing-fields
Mar 21, 2023
Merged

Add missing fields to JobsService#614
pietern merged 1 commit into
mainfrom
jobs-missing-fields

Conversation

@pietern

@pietern pietern commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Adds the webhook_notifications field to JobsService.

This change also renames the argument name_filter to name to match the API.

FYI @dinowernli

This change renames the argument `name_filter` to `name` to match the API.
@pietern

pietern commented Mar 13, 2023

Copy link
Copy Markdown
Contributor Author

Compat failure is due to name_filter -> name rename. Can be ignored.

@dinowernli dinowernli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pietern pietern merged commit dae9d9a into main Mar 21, 2023
@pietern pietern deleted the jobs-missing-fields branch March 21, 2023 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants