Query parameters: implement support for binding NULL parameters#189
Merged
Conversation
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
requested review from
andrefurlan-db,
arikfr,
nithinkdb,
superdupershant,
susodapop and
yunbodeng-db
as code owners
September 30, 2023 17:45
kravets-levko
temporarily deployed
to
azure-prod
September 30, 2023 17:45 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
kravets-levko
temporarily deployed
to
azure-prod
September 30, 2023 17:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
force-pushed
the
suport-null-query-parameters
branch
from
September 30, 2023 17:58
b2db97a to
e0da4f5
Compare
kravets-levko
temporarily deployed
to
azure-prod
September 30, 2023 17:59 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
susodapop
reviewed
Sep 30, 2023
susodapop
left a comment
susodapop
left a comment
There was a problem hiding this comment.
Looks good. Just one question about passing named values for these parameters. Ordinal passage is working but I think the current implementation might not work for named params.
susodapop
approved these changes
Sep 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for inferring NULL values passed to DBR as parameters. Both
nullandundefinedcould be used asNULLvalues.Related to databricks/databricks-sql-python#233