Skip to content

Fix proxy connection pool creation #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susodapop merged 4 commits into from
Jul 12, 2023
Merged

Fix proxy connection pool creation #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17b8365
fix proxy connection pool creation
sebbegg Jun 23, 2023
e5e4618
black'd
sebbegg Jun 23, 2023
9e6161b
Merge branch 'main' into fix-proxy
Jul 12, 2023
f90b185
Update changelog
Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Add support for Cloud Fetch
- Fix: Revised SQLAlchemy dialect and examples for compatibility with SQLAlchemy==1.3.x
- Fix: oauth would fail if expired credentials appeared in ~/.netrc
- Fix: Python HTTP proxies were broken after switch to urllib3

## 2.7.0 (2023-06-26)

Expand Down
5 changes: 4 additions & 1 deletion src/databricks/sql/auth/thrift_http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,10 @@ def open(self):
headers={"Proxy-Authorization": self.proxy_auth},
)
self.__pool = proxy_manager.connection_from_host(
self.host, self.port, pool_kwargs=_pool_kwargs
host=self.realhost,
port=self.realport,
scheme=self.scheme,
pool_kwargs=_pool_kwargs,
)
else:
self.__pool = pool_class(self.host, self.port, **_pool_kwargs)
Expand Down