Conversation
added 4 commits
October 25, 2023 11:41
Closes #207 Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
dev install with `poetry install --extras "async"` when deployed to pip this will be installable with `pip install databricks-sql-connector[async]` Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
requested review from
andrefurlan-db,
arikfr and
yunbodeng-db
as code owners
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
benc-db
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the path to implementing async/await we need to install
httpxas an extra dependency. The minimum Python version forhttpxis Python 3.8 so I bumped that as well, which was already planned in #207. To that end, this PR also reverts #208 which was a temporary fix until we dropped Python 3.7 support.We'll use the
asyncstaging branch for the PR's implementing this feature so as to keepmainclean.Usage
For development:
Once this is deployed to Pypi:
Related Tickets and Documents
#176
PECO-1143