Fix all mlops stacks tests#97
Merged
mingyu89 merged 8 commits intouse-asset-templatefrom Aug 26, 2023
Merged
Conversation
Signed-off-by: Mingyu Li <mingyu.li@databricks.com>
Signed-off-by: Mingyu Li <mingyu.li@databricks.com>
mingyu89
force-pushed
the
use-asset-templates-fix-tests
branch
from
1f4fbc5 to
3157c8a
Compare
arpitjasa-db
approved these changes
Aug 23, 2023
Contributor
arpitjasa-db
left a comment
arpitjasa-db
left a comment
There was a problem hiding this comment.
Reviewed offline with @mingyu89 but confirmed that we are not losing test coverage and that we have fixed all the tests based on the passing jobs
Signed-off-by: Mingyu Li <mingyu.li@databricks.com>
Signed-off-by: Mingyu Li <mingyu.li@databricks.com>
Signed-off-by: Mingyu Li <mingyu.li@databricks.com>
* Update docs Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Add more information about asset templats and link about databricks cli Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Fix doc issues Signed-off-by: Mingyu Li <mingyu.li@databricks.com> --------- Signed-off-by: Mingyu Li <mingyu.li@databricks.com>
mingyu89
added a commit
that referenced
this pull request
Sep 7, 2023
…eation (#96) * WIP Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Complete the implementation and fix all issues Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Skip the test data file when recipe is not used Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Add back support for root dir Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Fix all inconsistency issues based on validation Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Revert changes to stacks docs Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Replace azure_devlops with azure_devops Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Fix all mlops stacks tests (#97) * Fix all mlops stacks tests Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Remove all cookiecutter references from tests Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * black . Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Remove cookiecutter parameter file Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Rename more azure_devlops Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Bump version of databricks cli Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * update docs to remove cookiecutter and add asset bundle templates (#98) * Update docs Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Add more information about asset templats and link about databricks cli Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Fix doc issues Signed-off-by: Mingyu Li <mingyu.li@databricks.com> --------- Signed-off-by: Mingyu Li <mingyu.li@databricks.com> --------- Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Add order to the stacks template schema Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Update cli version to v0.204.0. Throw exception when users try to create project using cookiecutter Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Fix version used by test Signed-off-by: Mingyu Li <mingyu.li@databricks.com> * Fix tests by adding a dummy default profile to databricks CLI before generating project Signed-off-by: Mingyu Li <mingyu.li@databricks.com> --------- Signed-off-by: Mingyu Li <mingyu.li@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unit tests.
Created the separate PR for easier review.
Design doc and validation of migrating mlops stacks to use asset templates
https://docs.google.com/document/d/19MOK9o-f0A_-NMmxC1cJGQSQ2WkJXZ4vXQZ4plu-tng/edit#bookmark=id.tsk81t8hk8bf