This repository was archived by the owner on Jun 19, 2026. It is now read-only.
receive: reduce allocations with buffer pooling and enforce streaming size limits#287
Open
mkusumdb wants to merge 4 commits into
Open
receive: reduce allocations with buffer pooling and enforce streaming size limits#287mkusumdb wants to merge 4 commits into
mkusumdb wants to merge 4 commits into
Conversation
- Fixed handler to use HTTP header tenant when split label is missing - Updated test expectations to use full tenant ID format - All e2e tests passing with memory heap optimizations
yuchen-db
approved these changes
Feb 3, 2026
yuchen-db
left a comment
yuchen-db
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. how much saving of cpu/memory did you observe?
| // 2. Async remote write goroutines may still reference the labels | ||
| // 3. Even local writes need detached labels for TSDB storage | ||
| // Use the same intern setting as the writer to ensure consistent behavior. | ||
| for i := range wreq.Timeseries { |
Collaborator
There was a problem hiding this comment.
nit: we might want to do the same for exemplars as well
yuchen-db
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Verification