This repository was archived by the owner on Jun 19, 2026. It is now read-only.
receive: Detach exemplar labels from pooled buffer#289
Merged
Conversation
- Exemplars contain labels that also use ZLabel (zero-copy) - Without this fix, exemplar labels would still reference the pooled buffer - When the buffer is returned to the pool and reused, the exemplar labels would point to garbage data - This would cause data corruption or crashes The fix ensures both timeseries labels AND exemplar labels are detached from the pooled buffer before async processing.
yuchen-db
approved these changes
Feb 4, 2026
yuchen-db
pushed a commit
that referenced
this pull request
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in #283 where exemplar labels were not detached from the pooled buffer, causing potential use-after-free issues when buffers are reused.
Exemplars also contain labels using zero-copy ZLabels that reference the underlying buffer. When the buffer is returned to the pool and reused:
The fix ensures both timeseries labels AND exemplar labels are detached from the pooled buffer before async processing.