This repository was archived by the owner on Jun 19, 2026. It is now read-only.
receive: Add TSDB commit duration metric to receive writer#307
Merged
yishi3-db merged 2 commits intoMar 6, 2026
Conversation
Collaborator
|
Seems to be a high cardinality metric? |
Collaborator
@yuchen-db cardinality should be (16 histogram buckets) * (# of db pods) so |
yuchen-db
pushed a commit
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add a new Prometheus histogram metric
thanos_receive_writer_commit_duration_secondsto trackthe latency of TSDB
Commit()calls in the receive writer.Previously there was no way to observe how quickly metric samples are persisted to disk.
The existing
thanos_receive_write_e2e_latency_secondscovers full end-to-end ingestion latencybut does not isolate the disk commit step. This metric makes that visible so we can track
changes in storage performance over time.
Verification
go test -run TestWriter ./pkg/receive/...).