Skip to content

examples excluded#4

Closed
elenagaljak-db wants to merge 2 commits into
mainfrom
top_level_cargo
Closed

examples excluded#4
elenagaljak-db wants to merge 2 commits into
mainfrom
top_level_cargo

Conversation

@elenagaljak-db

Copy link
Copy Markdown
Collaborator

What changes are proposed in this pull request?

Provide the readers and reviewers with the information they need to understand
this PR in a comprehensive manner.

Specifically, try to answer the two following questions:

  • WHAT changes are being made in the PR? This should be a summary of the
    major changes to allow the reader to quickly understand the PR without having
    to look at the code.
  • WHY are these changes needed? This should provide the context that the
    reader might be missing. For example, were there any decisions behind the
    change that are not reflected in the code itself?

The “why part” is the most important of the two as it usually cannot be
inferred from the code itself. A well-written PR description will help future
developers (including your future self) to know how to interact and update your
code.

How is this tested?

Describe any tests you have done; especially if test tests are not part of
the unit tests (e.g. local tests).

ALWAYS ANSWER THIS QUESTION: Answer with "N/A" if tests are not applicable
to your PR (e.g. if the PR only modifies comments). Do not be afraid of
answering "Not tested" if the PR has not been tested. Being clear about what
has been done and not done provides important context to the reviewers.

@elenagaljak-db elenagaljak-db marked this pull request as ready for review October 6, 2025 15:08
zlata-stefanovic-db added a commit that referenced this pull request Jun 24, 2026
## Summary

The C++ SDK test suite (`tests/`) — the tiny hermetic in-repo harness plus unit
tests for config conversion, errors, the headers trampoline, proto schema, and
the SDK — and the `add_subdirectory(tests)` wiring.

Part of the #415 split (5/6).

### Merge order
**Stacked on #4 (core).** Merge after core; this branch is based on it.

Draft until the stack is reviewed.

Split from #415.

Signed-off-by: Zlata Stefanovic <zlata.stefanovic@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant