Fix version specification for redshift-connector#2467
Open
asnare wants to merge 2 commits into
Open
Conversation
It needs to be the current version or higher; downgrades aren't allowed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
=======================================
Coverage 65.05% 65.05%
=======================================
Files 107 107
Lines 9524 9524
Branches 1008 1008
=======================================
Hits 6196 6196
Misses 3149 3149
Partials 179 179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
m-abulazm
approved these changes
May 21, 2026
|
✅ 157/157 passed, 6 flaky, 3 skipped, 44m2s total Flaky tests:
Running from acceptance #4549 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes the version specification for the
redshift-connectordependency, introduced in #2305: as written it allows for higher 2.x versions (e.g. 2.2) as well as downgrades to earlier versions of the connector (e.g. 2.1.7) that were not used during development or tested.Relevant implementation details
When using
~=with semantic versioning, the complete minimum version needs to be specified.Linked issues
Noticed when reviewing #2466, which downgrades
redshift-connectorto escape a version constraint onlxml. Coincidentally includes #2464.