Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/image-processing/compare/md-outputs..md-outputs-PR-288 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-07-25 13:00:01 +0000 |
deppen8
left a comment
There was a problem hiding this comment.
Looks great! That must have been a good amount of work, so thank you, @tobyhodges .
One caveat is that I didn't try to find any references that you might have missed, but I am sure we will discover those in time.
|
Thanks @deppen8 |
Auto-generated via {sandpaper}
Source : 494d405
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2023-07-26 07:21:37 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 06c4504
Branch : main
Author : Toby Hodges <tbyhdgs@gmail.com>
Time : 2023-07-26 07:19:24 +0000
Message : Merge pull request #288 from datacarpentry/library-name-formatting
Consistent library naming
Auto-generated via {sandpaper}
Source : 494d405
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2023-07-26 07:21:37 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 06c4504
Branch : main
Author : Toby Hodges <tbyhdgs@gmail.com>
Time : 2023-07-26 07:19:24 +0000
Message : Merge pull request #288 from datacarpentry/library-name-formatting
Consistent library naming
Auto-generated via {sandpaper}
Source : 494d405
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2023-07-26 07:21:37 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 06c4504
Branch : main
Author : Toby Hodges <tbyhdgs@gmail.com>
Time : 2023-07-26 07:19:24 +0000
Message : Merge pull request #288 from datacarpentry/library-name-formatting
Consistent library naming
Auto-generated via {sandpaper}
Source : 494d405
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2023-07-26 07:21:37 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : 06c4504
Branch : main
Author : Toby Hodges <tbyhdgs@gmail.com>
Time : 2023-07-26 07:19:24 +0000
Message : Merge pull request #288 from datacarpentry/library-name-formatting
Consistent library naming
|
Hi @tobyhodges, Sorry for my super late reply here!
I'll speak under @stefanv's control. Based on usage (e.g., see website's landing page), I would strictly parallel " Following this convention, maybe the only 'leftover' would be in episode 02: -while `skimage` is dedicated to performing operations on the images.
+while scikit-image is dedicated to performing operations on the images.But this would raise the same question for " |
|
Thanks for circling back, @mkcor. Happy to update episode 02 according to your recommendation, but I will wait to hear about ImageIO so that I can handle all modifications together. |
|
It doesn't look as though imageio is capitalized in their docs: https://imageio.readthedocs.io/en/stable/ |
| - Define the terms bit, byte, kilobyte, megabyte, etc. | ||
| - Explain how a digital image is composed of pixels. | ||
| - Recommend using imageio (resp. skimage) for I/O (resp. image processing) tasks. | ||
| - Recommend using imageio (resp. scikit-image) for I/O (resp. image processing) tasks. |
There was a problem hiding this comment.
I'm surprised by this change because this is the version we already have on main:
| - Explain the left-hand coordinate system used in digital images. | ||
| - Explain the RGB additive colour model used in digital images. | ||
| - Explain the order of the three colour values in skimage images. | ||
| - Explain the order of the three colour values in scikit-image images. |
There was a problem hiding this comment.
Hmm, I'm not sure what 'scikit-image images' are... For now, in scikit-images, images are NumPy arrays (as taught in this lesson). Maybe the above was meant to be 'digital images?'
| ## Further Explanation | ||
|
|
||
| In the example above, form 1 loads the entire `skimage` library into the | ||
| In the example above, form 1 loads the entire scikit-image library into the |
There was a problem hiding this comment.
Here I would leave skimage because we are referring to code. We are actually importing Python modules, which must have all-lowercase names...
I took a pass through the lesson and made library names for Matplotlib, NumPy, and scikit-image consistent with how the projects refer to themselves. There were at least a couple of cases where I wasn't completely sure whether "
skimage" or "scikit-image" was more appropriate but I think I took care of the vast majority of cases.