Skip to content

Use import tool report for EMPTY_IMPORT_CHECK#1975

Merged
vish-cs merged 2 commits intodatacommonsorg:masterfrom
vish-cs:maifest
Apr 24, 2026
Merged

Use import tool report for EMPTY_IMPORT_CHECK#1975
vish-cs merged 2 commits intodatacommonsorg:masterfrom
vish-cs:maifest

Conversation

@vish-cs
Copy link
Copy Markdown
Contributor

@vish-cs vish-cs commented Apr 22, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes redundant logging in the file uploader, updates workflow IDs in logs, and modifies the import helper to use a more specific file pattern for graph paths. Additionally, the manifest configuration was updated to include graph_data_path and remove cron schedules and resource limits. Review feedback highlighted a naming inconsistency between the code and the manifest for the graph data path attribute, as well as a concern regarding the redirection of command output to a log file in the download script, which could hinder debugging.

Comment thread import-automation/workflow/import-helper/main.py Outdated
Comment thread scripts/entities/download.sh
Comment thread tools/import_validation/validator.py Outdated
Comment thread tools/import_validation/validator.py Outdated
@vish-cs vish-cs force-pushed the maifest branch 2 times, most recently from 3c315f2 to 9571653 Compare April 23, 2026 05:27
@vish-cs vish-cs changed the title Import executor clean up Use import tool report for EMPTY_IMPORT_CHECK Apr 23, 2026
@vish-cs vish-cs force-pushed the maifest branch 2 times, most recently from 29a80b7 to d9daa21 Compare April 24, 2026 17:05
@vish-cs vish-cs merged commit 72cc595 into datacommonsorg:master Apr 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants