skipped the redundant ids coming in output#1979
Open
niveditasing wants to merge 2 commits intodatacommonsorg:masterfrom
Open
skipped the redundant ids coming in output#1979niveditasing wants to merge 2 commits intodatacommonsorg:masterfrom
niveditasing wants to merge 2 commits intodatacommonsorg:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a filtering step to skip redundant 'Extra-Regio' IDs during the data cleaning process. A review comment suggests replacing the hardcoded list of IDs with a more robust pattern-based filter to ensure all similar redundant codes are captured consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Eurostat (and NUTS) classification system, HU is the code for Hungary.
The specific codes (HUX, HUXX ,EEXX ) follow a hierarchical structure used for statistical reporting. Here is the breakdown:
Country & Regional Codes
HU: The 2-letter ISO/Eurostat country code for Hungary.
HUX: This refers to "Extra-Regio" territory for Hungary at the NUTS 1 level.
HUXXX: This refers to "Extra-Regio" territory at the NUTS 3 level.
Hence the codes are undefined & also the dcids for these mapping does not exist in DC & throwing ObservatioAbout error so as a fix we are skipping these