Make field on Incremental tables default to false as it was before. - #1942
Merged
Conversation
Ceridan
requested review from
DiasDauletov and
kolina
and removed request for
a team and
DiasDauletov
March 25, 2025 10:41
kolina
approved these changes
Mar 25, 2025
Merged
1 task
potiuk
pushed a commit
to apache/airflow
that referenced
this pull request
Aug 1, 2026
The reverted change was meant to fix #53843 (invocation_config believed dropped when workflow_invocation is passed as a dict), but it is a wire-identical no-op: proto-plus already converts nested dicts recursively, and the pre- and post-change requests serialize byte-identically, so the dict path never dropped the config. The reported symptom came from dataform-core 3.0.10-3.0.16 defaulting incremental tables to protected=true (silently disabling full refresh server-side; fixed upstream in core 3.0.17 via dataform-co/dataform#1942). #53843 is closed as not planned. The accompanying test only pinned third-party proto-plus conversion behavior, which our testing standards exclude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configs refactoring introduced by #1780 changes the default behavior of
protectedfield on Incremental tables, see #1914The current PR changes the default behavior to make it consistent with what we had before:
protectedfield set, then the value of the field will be used.protectedfield, it will be set to false.protectedwill be set to false..protected()will be called without arguments (like it was possible before) then the field will be set to through..protected()will be called with argument (true or false) then the field will be set to the value of the argument passed.The logic is quite complicated here but we are trying to mimic the previous behavior to preserve backward compatibility.
Closes #1914