Deleting unecessary API (Sourcery refactored)#135
Conversation
5329ddd to
22447a3
Compare
| definition = {} | ||
| definition['name'] = cluster_name | ||
| definition['type'] = cluster_type | ||
| definition['params'] = params if params is not None else {} | ||
| definition = { | ||
| 'name': cluster_name, | ||
| 'type': cluster_type, | ||
| 'params': params if params is not None else {}, | ||
| } | ||
|
|
There was a problem hiding this comment.
Function DSSClient.create_cluster refactored with the following changes:
- Merge dictionary assignment with declaration (
merge-dict-assign)
| if isinstance(v, str) or isinstance(v, unicode): | ||
| if isinstance(v, (str, unicode)): |
There was a problem hiding this comment.
Function DSSClient.make_entry refactored with the following changes:
- Merge isinstance calls (
merge-is-instance)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.34%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
Pull Request #134 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
fix/dss-90-jupyter-api-rmbranch, then run: