Skip to content

Jupyter notebook / last polish#138

Merged
pbailly merged 1 commit into
release/9.0from
fix/dss901-jupyter-notebook-last-polish
Mar 31, 2021
Merged

Jupyter notebook / last polish#138
pbailly merged 1 commit into
release/9.0from
fix/dss901-jupyter-notebook-last-polish

Conversation

@apichery

Copy link
Copy Markdown
Contributor

No description provided.

@apichery apichery added this to the 9.0.1 milestone Mar 31, 2021
@sourcery-ai

sourcery-ai Bot commented Mar 31, 2021

Copy link
Copy Markdown

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.04%.

Quality metrics Before After Change
Complexity 2.45 ⭐ 2.45 ⭐ 0.00
Method Length 31.93 ⭐ 32.03 ⭐ 0.10 👎
Working memory 8.52 🙂 8.54 🙂 0.02 👎
Quality 79.49% 79.45% -0.04% 👎
Other metrics Before After Change
Lines 1425 1425 0
Changed files Quality Before Quality After Quality Change
dataikuapi/dss/project.py 79.49% ⭐ 79.45% ⭐ -0.04% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
dataikuapi/dss/project.py DSSProject.new_recipe 17 🙂 180 😞 28 ⛔ 29.17% 😞 Try splitting into smaller methods. Extract out complex expressions
dataikuapi/dss/project.py DSSProject.duplicate 2 ⭐ 73 🙂 18 ⛔ 60.05% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.create_prediction_ml_task 2 ⭐ 75 🙂 14 😞 63.99% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.list_jupyter_notebooks 5 ⭐ 69 🙂 12 😞 64.92% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.list_datasets 5 ⭐ 63 🙂 12 😞 65.84% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@pbailly pbailly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbailly pbailly merged commit fe66dfb into release/9.0 Mar 31, 2021
@pbailly pbailly deleted the fix/dss901-jupyter-notebook-last-polish branch March 31, 2021 18:47
Comment thread dataikuapi/dss/project.py
@@ -839,11 +839,11 @@ def list_jupyter_notebooks(self, active=False, as_type="object"):
:returns: The list of the notebooks. If "as_type" is "names", each one as a string, if "as_type" is "objects", each one as a :class:`dataikuapi.dss.notebook.DSSJupyterNotebook`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apichery Hi the return explanation here If "as_type" is "names" is wrong, maybe you forgot to change it. I guess you can just say:
If "as_type" is "listitems", then each one as a dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants