Add wrappers for dashboards and insights#250
Closed
adescamps wants to merge 2 commits into
Closed
Conversation
[sc-95092] [sc-95094]
|
This pull request has been linked to: |
joubert-m
reviewed
Aug 3, 2022
| self.client = client | ||
|
|
||
| def to_dashboard(self): | ||
| return DSSDashboard(self.client, self._data["projectKey"], self._data["id"]) |
There was a problem hiding this comment.
we sometimes use " and sometimes ' for string we should harmonise it a bit
Co-authored-by: joubert-m <theojoubertmoureaud@gmail.com>
geraldlamory
left a comment
geraldlamory
left a comment
There was a problem hiding this comment.
Tested manually, it works well. And the code looks good 👍
Maybe we could add an argument to list_insights to retrieve insights as a list of DSSInsightListItem like for dashboards ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[sc-95092]
[sc-95094]