Skip to content

Make date range start fully optional when querying #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nblumhardt merged 1 commit into from
Feb 19, 2018
Merged

Make date range start fully optional when querying #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/Seq.Api/ResourceGroups/DataResourceGroup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ internal DataResourceGroup(ISeqConnection connection)
/// <returns>A structured result set.</returns>
public async Task<QueryResultPart> QueryAsync(
string query,
DateTime rangeStartUtc,
DateTime? rangeStartUtc = null,
DateTime? rangeEndUtc = null,
SignalExpressionPart signal = null,
SignalEntity unsavedSignal = null,
Expand All @@ -49,7 +49,7 @@ public async Task<QueryResultPart> QueryAsync(
/// <returns>A CSV result set.</returns>
public async Task<string> QueryCsvAsync(
string query,
DateTime rangeStartUtc,
DateTime? rangeStartUtc = null,
DateTime? rangeEndUtc = null,
SignalExpressionPart signal = null,
SignalEntity unsavedSignal = null,
Expand All @@ -62,7 +62,7 @@ public async Task<string> QueryCsvAsync(

static void MakeParameters(
string query,
DateTime rangeStartUtc,
DateTime? rangeStartUtc,
DateTime? rangeEndUtc,
SignalExpressionPart signal,
SignalEntity unsavedSignal,
Expand All @@ -72,10 +72,13 @@ static void MakeParameters(
{
parameters = new Dictionary<string, object>
{
{"q", query},
{nameof(rangeStartUtc), rangeStartUtc}
{"q", query}
};

if (rangeStartUtc != null)
{
parameters.Add(nameof(rangeStartUtc), rangeStartUtc);
}
if (rangeEndUtc != null)
{
parameters.Add(nameof(rangeEndUtc), rangeEndUtc.Value);
Expand Down