Add support for handling the remote configuration ( MinimumLevelAccepted ) - #23
Conversation
|
Looking forward to this feature, anything blocking it? |
|
Sorry for the delay on this, looking now! |
| .then(() => seq.close()); | ||
|
|
||
| async function sayHello(times) { | ||
| n = n + 1; |
|
Hi @mlabrum - apologies, it's been a while - thanks for taking the time to submit this PR. May I ask if you're using |
|
It's all good I know how it is with working on open source projects. At the time I was writing this I was using https://www.npmjs.com/package/winston and wrote a custom seq logging library for it ( that I haven't open sourced yet, I was waiting for this PR... then moved onto another internal project) that when this callback is called will alter the logging level of Winston. The idea was to introduce the functionality into the base logging library, then the community ( or myself as I use other libraries) will add support for this feature, as its one of the killer features of SEQ. ( in my opinion ) |
|
Fantastic, thanks for that. I'll merge it in 👍 If we can help with the |
Hi All,
Thanks for accepting my previous pull request.
I really liked the idea of the feature to dynamically toggle applications log levels within Seq and noticed that the JS loggers don't have support for this yet. So I've added a callback which gets called any time the remote configuration changes.
I also added another example which sends the Seq events slower to be able to test this.
Let me know if you need me to change anything :)