Add support for a subcommand - #26
Merged
Merged
Conversation
andymac4182
force-pushed
the
subcommand
branch
from
February 24, 2018 05:58
9201f4b to
8634d60
Compare
andymac4182
changed the title
Member
|
Thanks for the PR! Looks great 👍 will check it out in the morning with fresh eyes :-) |
andymac4182
force-pushed
the
subcommand
branch
from
February 25, 2018 00:02
e5cc07c to
929ef8a
Compare
Contributor
Author
|
From my perspective this is good to go now. There should be tests for the new logic and ensuring I didn't break old logic. |
Member
|
I think we'll need to add some more tweaks to get: and working with it, but seems like a good time to push this through to unblock #27 :-) Thanks again! |
Contributor
Author
|
I will have a look at help to see if I can get that working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is designed to allow for the first proposal in #2.
I am building a proposal for API Key management which is where this came from.