This repository was archived by the owner on Apr 17, 2018. It is now read-only.
Unify naming & partially unify implementation of dm-timestamps & Paranoid*#32
Closed
emmanuel wants to merge 13 commits into
Closed
Unify naming & partially unify implementation of dm-timestamps & Paranoid*#32emmanuel wants to merge 13 commits into
emmanuel wants to merge 13 commits into
Conversation
This is in the Enum#initialize method, how could this test ever be false? In other words, how could any instance that doesn't inherit from Property::Enum execute the Property::Enum#initialize method?
This includes (roughly) ported specs from dm-timestamps.
…noidResource::ClassMethods#paranoid_properties. Move actually setting resource attribute into Property#stamp_resource. Also, use #[]= instead of attribute_set (#[]= allows ||=).
…troyed::DateTime.
Contributor
|
@emmanuel I think we agreed that it's not gonna be merged in. so if you don't mind, I will close it, ok? |
Member
Author
|
We did agree that this was not the right direction to go: adding Resource lifecycle responsibilities to Property introduces more coupling. I think something like (my interceptors spike)[https://github.com/emmanuel/dm-core/compare/datamapper:master...emmanuel:feature/interceptors] will be a better direction instead. Go ahead and close this. On Sep 14, 2011, at 2:13 AM, Piotr Solnica wrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the third of 3 pull requests from decomposing the many changes in #24. It is a superset of the changes in #30 and #31.
These changes subsume dm-timestamps into dm-types and unify the naming of Paranoid* to align with the naming. This results in:
:created_on->Created::Date:created_at->Created::DateTime:updated_on->Updated::Date:updated_at->Updated::DateTimeParanoidBoolean->Destroyed::BooleanParanoidDateTime->Destroyed::DateTimeI haven't ported the
Model#timestampsmacro fromdm-timestamps(labeled as implicit property declaration in thedm-timestampsspecs). My thinking is that if these changes (#30, #31 and this) are integrated, theModel#timestampsmacro may remain in an updateddm-timestampsgem which merely provides a dependency ondm-typesand a method or two for backwards compatibility.