feat: Add Google Gemini API support to Lambda proxy#2
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request extends the existing Lambda proxy to support the Google Gemini API alongside the current OpenAI functionality. The implementation adheres to the provided gold standard for Gemini API interaction and ensures that existing OpenAI features remain unaffected.
Changes Implemented
@google/generative-ai: Added the necessary library for Gemini API communication.openai_servers.yaml: Added ageminiconfiguration entry, including API token and model specification, while omitting the URL as per client library behavior.src/gemini_settings.ts: Introduced aGeminiSettingsinterface for type-safe Gemini configurations.src/llm_client.ts:OpenAiSettings | GeminiSettings.urlpresence for OpenAI).chatCompletionStreamingfor Gemini, precisely mimicking the provided gold standard example (usinggetGenerativeModel,startChat, andsendMessageStream).src/llm_proxy.ts:transformGeneratorandformatChunkfunctions to handle stream data from both OpenAI and Gemini.getLlmClientto correctly instantiateLlmClientwith eitherOpenAiSettingsorGeminiSettings.OpenAiServerSettings | Record<string, GeminiSettings>.src/app_settings.ts:getOpenAiServerSettingswithgetAllServerSettings.getAllServerSettingsto correctly parse and differentiate between OpenAI and Gemini configurations fromopenai_servers.yamlbased on the presence of theurlkey.src/index.ts:getAllServerSettingsfunction.src/tests/index.test.ts:getAllServerSettings.package.json:@google/generative-aiandweb-streams-polyfillto dependencies.buildscript inpackage.jsonto mark@google/genaias an external dependency foresbuild.package-lock.json: Reflects new dependencies.How to Test
openai_servers.yamlhas a validgeminientry with an API key and model./gemini/v1/chat/completionsendpoint.npm testto ensure all unit and integration tests pass.This implementation fulfills the objective of integrating Gemini support while maintaining existing functionalities.