New-DbaLogin: add ExternalGroup support and SQL Server 2022 Entra login handling#10225
Merged
Merged
Conversation
…in handling Fixes Copy-DbaLogin and Sync-DbaAvailabilityGroup not syncing Azure Entra logins (ExternalUser/ExternalGroup) on SQL Server 2022. Two issues were addressed: 1. ExternalGroup login type was not included in the SMO Create() path or property-setting block, causing it to fall through to FROM WINDOWS T-SQL which fails for Entra group logins. 2. The T-SQL fallback for FROM EXTERNAL PROVIDER only triggered for Azure SQL DB and Managed Instance, but SQL Server 2022 (version 16+) also supports this syntax for Entra logins. (do *Login*) Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
Member
|
awesome ty 🙏🏼 |
potatoqualitee
added a commit
that referenced
this pull request
Apr 10, 2026
… of #10225) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #damagetools_9586
Fixes Copy-DbaLogin and Sync-DbaAvailabilityGroup not syncing Azure Entra logins (ExternalUser/ExternalGroup) on SQL Server 2022.
Two issues were addressed:
Fixes #9586
Generated with Claude Code