Skip to content

fix CA spelling errors and update following official gramatical rules#1289

Merged
kossnocorp merged 1 commit into
date-fns:masterfrom
uxland:ca-spelling-corrections
Aug 16, 2019
Merged

fix CA spelling errors and update following official gramatical rules#1289
kossnocorp merged 1 commit into
date-fns:masterfrom
uxland:ca-spelling-corrections

Conversation

@avizcaino
Copy link
Copy Markdown
Contributor

I've updated catalan locale with some gramatical corrections and following official gramatical rules.

@avizcaino avizcaino mentioned this pull request Aug 13, 2019
@avizcaino avizcaino requested a review from kossnocorp August 13, 2019 15:03
@avizcaino
Copy link
Copy Markdown
Contributor Author

Seems there is a problem with the Coverage report stage on Travis. I reopen #1079 for further investigation.

@kossnocorp kossnocorp added this to the Next release milestone Aug 15, 2019
Copy link
Copy Markdown
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you a lot for making it better. cc @date-fns/i18n-ca

@kossnocorp
Copy link
Copy Markdown
Member

I'll leave it open for some time in case others would have any comments. If there are no comments or everything's fine, I'll merge and ship it later today or this week.

@avizcaino
Copy link
Copy Markdown
Contributor Author

Great!

@kossnocorp kossnocorp merged commit 96d2d7b into date-fns:master Aug 16, 2019
@avizcaino avizcaino deleted the ca-spelling-corrections branch August 16, 2019 12:08
@kossnocorp
Copy link
Copy Markdown
Member

Thank you again, I've shipped this PR as v2.0.0-beta.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants